Revise FactCheckingEvaluator #4675
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. use required arguments as parameters of `builder()`. 2. deprecate constructors. See spring-projects#4652 Signed-off-by: Yanming Zhou <[email protected]>
quaff
commented
Oct 20, 2025
| * evaluation | ||
| * @deprecated in favor of {@link #builder(ChatClient.Builder)} | ||
| */ | ||
| @Deprecated(forRemoval = true) |
There was a problem hiding this comment.
Could it be removed instead of deprecated?
There was a problem hiding this comment.
We keep the deprecations latest for one release (even for milestone) before removing.
quaff
commented
Oct 20, 2025
| * @deprecated in favor of {@link #builder(ChatClient.Builder)} | ||
| */ | ||
| @Deprecated | ||
| public FactCheckingEvaluator(ChatClient.Builder chatClientBuilder, @Nullable String evaluationPrompt) { |
There was a problem hiding this comment.
Could it be private instead of deprecated?
There was a problem hiding this comment.
Let's keep this as is until we can completely remove it right after 1.1.0-M4.
There was a problem hiding this comment.
I realise this is the constructor used by the builder for instantiation. We should mark this private then.
|
@ericbottard Please review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
builder().See #4652