Skip to content

chore(ollama): remove unused parameters of request record #4677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore(ollama): remove unused parameters of request record #4677

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions models/spring-ai-ollama/src/main/java/org/springframework/ai/ollama/api/OllamaApi.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -685,12 +685,10 @@ public record ListModelResponse(
@JsonInclude(Include.NON_NULL)
public record ShowModelRequest(
@JsonProperty("model") String model,
@JsonProperty("system") String system,
@JsonProperty("verbose") Boolean verbose,
@JsonProperty("options") Map<String, Object> options
@JsonProperty("verbose") Boolean verbose
) {
public ShowModelRequest(String model) {
this(model, null, null, null);
this(model, null);
}
}

Expand Down Expand Up @@ -725,8 +723,7 @@ public record DeleteModelRequest(
public record PullModelRequest(
@JsonProperty("model") String model,
@JsonProperty("insecure") boolean insecure,
@JsonProperty("username") String username,
@JsonProperty("password") String password,

@JsonProperty("stream") boolean stream
) {
public PullModelRequest {
Expand All @@ -737,7 +734,7 @@ public record PullModelRequest(
}

public PullModelRequest(String model) {
this(model, false, null, null, true);
this(model, false, true);
}
}

Expand Down