Rename Toolcallback to ToolCallback for better naming consistency #4685
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
huidongyin
commented
Oct 21, 2025
huidongyin
commented
- Rename internal class ToolCallback to ToolCallbackConfig in McpClientCommonProperties
- Update field name from toolCallback to toolCallbackConfig
- Update getter/setter methods to match new naming convention
- Update configuration property path from .toolcallback to .tool-callback
- Update all related test files to use new configuration property names
- All tests pass and functionality remains intact
huidongyin
force-pushed
the
rename-toolcallback-to-toolcallbackconfig
branch
from
67c1e67 to
772543c
Compare
- Keep ToolCallback as internal class name in McpClientCommonProperties - Maintain toolCallback field name and getter/setter methods - Use .toolcallback configuration property path - Update all related test files to use consistent naming - All tests pass and functionality remains intact This change ensures naming consistency with Spring AI project conventions where Properties internal classes use descriptive names rather than Config suffixes. Signed-off-by: huidong.yin <[email protected]>
huidongyin
force-pushed
the
rename-toolcallback-to-toolcallbackconfig
branch
from
772543c to
759a5b8
Compare
huidongyin
changed the title
quaff
reviewed
Oct 21, 2025
...springframework/ai/mcp/client/common/autoconfigure/properties/McpClientCommonProperties.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.