Add support for Elasticsearch vector store: Squashed #471
Conversation
Add ElasticsearchAiSearchFilterExpressionConverter
…arent pom and Bom pom
…es the use of epoch milliseconds
| <module>models/spring-ai-mistral-ai</module> | ||
| <module>models/spring-ai-vertex-ai-palm2</module> | ||
| <module>models/spring-ai-vertex-ai-gemini</module> | ||
| <module>models/spring-ai-anthropic</module> |
There was a problem hiding this comment.
this is a valid module. Why did you delete it?
| <module>vector-stores/spring-ai-azure</module> | ||
| <module>vector-stores/spring-ai-weaviate</module> | ||
| <module>vector-stores/spring-ai-redis</module> | ||
| <module>vector-stores/spring-ai-gemfire</module> |
There was a problem hiding this comment.
Valid module. should not be deleted.
| <module>vector-stores/spring-ai-mongodb-atlas-store</module> | ||
| <module>spring-ai-spring-boot-starters/spring-ai-starter-mongodb-atlas-store</module> | ||
| <module>spring-ai-spring-boot-testcontainers</module> | ||
| <module>spring-ai-spring-boot-starters/spring-ai-starter-anthropic</module> |
There was a problem hiding this comment.
All
<module>vector-stores/spring-ai-mongodb-atlas-store</module>
<module>spring-ai-spring-boot-starters/spring-ai-starter-mongodb-atlas-store</module>
<module>spring-ai-spring-boot-testcontainers</module>
<module>spring-ai-spring-boot-starters/spring-ai-starter-anthropic</module>
Are valid and used modules. Should not be deleted.
| <jtokkit.version>1.0.0</jtokkit.version> | ||
| <victools.version>4.31.1</victools.version> | ||
| <bedrockruntime.version>2.25.3</bedrockruntime.version> | ||
| <bedrockruntime.version>2.24.8</bedrockruntime.version> |
There was a problem hiding this comment.
Why the Bedrock runtime is downgrated? It is not related to ES
|
|
||
| <!-- testing dependencies --> | ||
| <testcontainers.version>1.19.7</testcontainers.version> | ||
| <testcontainers.version>1.19.6</testcontainers.version> |
There was a problem hiding this comment.
Same here. This version shouldn't be downgraded
|
|
||
| <dependency> | ||
| <groupId>org.springframework.ai</groupId> | ||
| <artifactId>spring-ai-mongodb-atlas-store</artifactId> |
There was a problem hiding this comment.
the spring-ai-mongodb-atlas-store is used. Why is it deleted?
| @BeforeEach | ||
| void cleanDatabase() { | ||
| getContextRunner().run(context -> { | ||
| // Generating test data for documents with embedding values |
There was a problem hiding this comment.
What is this and why it is commented out?
| }); | ||
| vectorStore.add(documents); | ||
|
|
||
| // List<Double> embedding = |
There was a problem hiding this comment.
What is the reason to use preloaded json files instead of Document instances?
|
@JM-Lab , thank you for your contribution. |
|
Rebased, squashed and merged at 9334d7d |
2 participants
Squashed Commits from PR #234