GH-3442: Fix MySQL/MariaDB message ordering in JdbcChatMemoryRepository#4739
Closed
sobychacko wants to merge 1 commit intospring-projects:mainfrom
Closed
GH-3442: Fix MySQL/MariaDB message ordering in JdbcChatMemoryRepository#4739sobychacko wants to merge 1 commit intospring-projects:mainfrom
sobychacko wants to merge 1 commit intospring-projects:mainfrom
Conversation
…tMemoryRepository Fixes spring-projects#3442 Change timestamp generation to use second-level granularity instead of milliseconds to ensure compatibility with MySQL/MariaDB default TIMESTAMP precision (0 decimal places). The old code used millisecond timestamps that were truncated to seconds on storage, causing messages saved within the same second to have identical timestamps and random ordering. The timestamp field functions as a sequence ID for message ordering rather than a precise temporal record. Using second-level granularity with proper incrementing ensures correct ordering across all database timestamp precisions without requiring schema changes. Also adds testMessageOrderWithLargeBatch() that saves 50 messages to validate ordering is preserved. The original test with only 4 messages was passing by chance despite the underlying bug. Signed-off-by: Soby Chacko <soby.chacko@broadcom.com>
This was referenced Oct 28, 2025
sunyuhan1998
approved these changes
Oct 28, 2025
ilayaperumalg
approved these changes
Oct 28, 2025
Member
|
Rebased and merged as d2492a6. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3442
Change timestamp generation to use second-level granularity instead of milliseconds to ensure compatibility with MySQL/MariaDB default TIMESTAMP precision (0 decimal places). The old code used millisecond timestamps that were truncated to seconds on storage, causing messages saved within the same second to have identical timestamps and random ordering.
The timestamp field functions as a sequence ID for message ordering rather than a precise temporal record. Using second-level granularity with proper incrementing ensures correct ordering across all database timestamp precisions without requiring schema changes.
Also adds testMessageOrderWithLargeBatch() that saves 50 messages to validate ordering is preserved. The original test with only 4 messages was passing by chance despite the underlying bug.
Thank you for taking time to contribute this pull request!
You might have already read the contributor guide, but as a reminder, please make sure to:
git commit -s) per the DCOmainbranch and squash your commitsFor more details, please check the contributor guide.
Thank you upfront!