-
Notifications
You must be signed in to change notification settings - Fork 2k
Add bedrock profile autoconfiguration support and replace deprecated #4742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jiangbaojun
wants to merge
6
commits into
spring-projects:main
Choose a base branch
from
jiangbaojun:bedrock_connection_config
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
498d4a9
Add bedrock profile autoconfiguration support and replace deprecated
jiangbaojun 3b49357
Merge remote-tracking branch 'upstream/main' into bedrock_connection_…
jiangbaojun f0ba84a
Update bedrock configuration test case and document
jiangbaojun 6f46278
Merge remote-tracking branch 'upstream/main' into bedrock_connection_…
jiangbaojun 7a28ae7
Merge remote-tracking branch 'refs/remotes/upstream/main' into bedroc…
jiangbaojun 359eb28
Update bedrock document
jiangbaojun File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
65 changes: 65 additions & 0 deletions
65
...i/src/main/java/org/springframework/ai/model/bedrock/autoconfigure/ProfileProperties.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,65 @@ | ||
| /* | ||
| * Copyright 2023-2024 the original author or authors. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * https://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.springframework.ai.model.bedrock.autoconfigure; | ||
|
|
||
| /** | ||
| * Configuration properties for Bedrock AWS connection using profile. | ||
| * | ||
| * @author Baojun Jiang | ||
| */ | ||
| public class ProfileProperties { | ||
|
|
||
| /** | ||
| * Name of the profile to use. | ||
| */ | ||
| private String name; | ||
|
|
||
| /** | ||
| * (optional) Path to the credentials file. default: ~/.aws/credentials | ||
| */ | ||
| private String credentialsPath; | ||
|
|
||
| /** | ||
| * (optional) Path to the configuration file. default: ~/.aws/config | ||
| */ | ||
| private String configurationPath; | ||
|
|
||
| public String getName() { | ||
| return this.name; | ||
| } | ||
|
|
||
| public void setName(String name) { | ||
| this.name = name; | ||
| } | ||
|
|
||
| public String getCredentialsPath() { | ||
| return this.credentialsPath; | ||
| } | ||
|
|
||
| public void setCredentialsPath(String credentialsPath) { | ||
| this.credentialsPath = credentialsPath; | ||
| } | ||
|
|
||
| public String getConfigurationPath() { | ||
| return this.configurationPath; | ||
| } | ||
|
|
||
| public void setConfigurationPath(String configurationPath) { | ||
| this.configurationPath = configurationPath; | ||
| } | ||
|
|
||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use an
elsebranch to make it clear that this is the 3rd exclusive caseThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I will update later
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ericbottard,
I had added tests and updated the documentation