Skip to content

GH-4787: Include exception in call to logger when tool execution fails #4788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

GH-4787: Include exception in call to logger when tool execution fails #4788

wants to merge 1 commit into from

Conversation

@mkjensen
Copy link
Contributor

@mkjensen mkjensen commented Nov 3, 2025 •
edited
Loading

Add exception as argument to logger call when tool execution fails.

Issue: #4787

liugddx
liugddx approved these changes Nov 3, 2025
View reviewed changes
Copy link
Contributor

@liugddx liugddx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ilayaperumalg ilayaperumalg added this to the 1.1.0.RC1 milestone Nov 4, 2025
@ilayaperumalg ilayaperumalg self-assigned this Nov 4, 2025
@ilayaperumalg
Copy link
Member

ilayaperumalg commented Nov 4, 2025

@mkjensen Thanks for the PR and @liugddx thanks for the review.

LGTM, Rebased and merged as c5ce4be

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@liugddx liugddx liugddx approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ilayaperumalg ilayaperumalg

Labels

tool/function calling

Projects

None yet

Milestone

1.1.0.RC1

Development

Successfully merging this pull request may close these issues.

3 participants

@mkjensen @ilayaperumalg @liugddx