Feat: Add additional parameter to WatsonxAiChatOptions #539
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tzolov
requested changes
Apr 4, 2024
| * 1.1) will be more lenient. (Default: 1.0) | ||
| */ | ||
| @JsonProperty("repetition_penalty") private Float repetitionPenalty; | ||
| @JsonProperty("repetition_penalty") private Float repetitionPenalty = 1.0f; |
There was a problem hiding this comment.
Do not set default values here but your default instance in
or
tzolov
approved these changes
Apr 4, 2024
tzolov
reviewed
Apr 4, 2024
|
|
||
| public static class Builder { | ||
| private final String input; | ||
| public static final String MODEL_PARAMETER_IS_REQUIRED = "Model parameter is required";private final String input; |
There was a problem hiding this comment.
This looks awkward.
Please run ./mvnw spring-javaformat:apply
There was a problem hiding this comment.
Right, apologies, I did the build and it passed so I thought the code linting was right
|
Rebased, squashed and merged at ae6a019 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some custom models may include extra parameters, so the idea is to define all the common parameters but add and additional attribute that will store all these custom configuration parameters. This will also help with its maintaniablitiy as if new parameters are added we can still use it while the options are not updated.