GH-5654: fix: clear entire conversation history in RedisChatMemoryRepository#5655
Open
jbl428 wants to merge 1 commit intospring-projects:mainfrom
Open
GH-5654: fix: clear entire conversation history in RedisChatMemoryRepository#5655jbl428 wants to merge 1 commit intospring-projects:mainfrom
jbl428 wants to merge 1 commit intospring-projects:mainfrom
Conversation
- Delete conversation documents in repeated search batches using configured max messages size. - Add integration test coverage for clearing conversations with more than ten messages. Signed-off-by: Jake Son <sonjeabin@gmail.com>
jbl428
changed the title
jbl428
changed the title
jbl428
commented
Mar 22, 2026
| } | ||
|
|
||
| try (Pipeline pipeline = jedis.pipelined()) { | ||
| result.getDocuments().forEach(doc -> pipeline.del(doc.getId())); |
Author
There was a problem hiding this comment.
Would it make sense to use UNLINK instead of DEL here for conversation cleanup?
It might reduce blocking during large deletes while keeping the same user-facing behavior.
If this sounds reasonable, I can either include it in this PR or open a separate issue for follow-up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #5654