GH-5656: Fix AzureOpenAiChatOptions.stop field initializer regression#5661
Open
ZhangDT-sky wants to merge 1 commit intospring-projects:mainfrom
Open
GH-5656: Fix AzureOpenAiChatOptions.stop field initializer regression#5661ZhangDT-sky wants to merge 1 commit intospring-projects:mainfrom
ZhangDT-sky wants to merge 1 commit intospring-projects:mainfrom
Conversation
…izer regression This PR fixes a regression where the 'stop' field in 'AzureOpenAiChatOptions' was initialized to an empty 'ArrayList'. This caused the JSON payload to always include '"stop": []', which is rejected by Azure OpenAI reasoning models (o1, o3). Changes: - Removed default initialization of the 'stop' field. - Added a regression test in 'AzureOpenAiChatOptionsTests' to ensure 'stop' remains 'null' after options merging/Jackson roundtrips. Closes spring-projects#5656 Signed-off-by: ZhangDT-sky <485918776@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a regression where the
stopfield inAzureOpenAiChatOptionswas initialized to an emptyArrayList. This caused the JSON payload to always include"stop": [], which is rejected by Azure OpenAI reasoning models (e.g., o1, o3).Changes:
stopfield.AzureOpenAiChatOptionsTeststo ensure thestopfield remainsnullafter options merging and Jackson roundtrips.Fixes #5656