-
Notifications
You must be signed in to change notification settings - Fork 2k
Bedrock client auto-configuration support external AwsCredentialsProvider and AwsRegionProvider #590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@tzolov Could you check this out? I know this is a breakable change. But it's very helpful for some of the projects that are using Spring Cloud AWS and Spring AI for AWS Bedrock usage. Looking forward to your suggestions. |
Hi @wmz7year, thanks for taking a pick at this. Before we start reviewing it i have to point that the So please cherry pick only the necessary minim of dependency. Often the awspring starters will try to bring the entire AWS ecosystem into your project. |
Maybe there is another solution for the compatibility between Spring-AI and Spring-Cloud-AWS. Sprint AI defined connection properties in But currently, we don't use So maybe we can keep the current So this will be compatible with Spring-Cloud-AWS and not necessarily integrated with it. How do you think about this, if this is ok I'll change the PR @tzolov |
66aadca
to
89c67ac
Compare
Hi @tzolov could you check this out again? I removed spring-cloud-aws dependency and provided new capabilities with custom |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @wmz7year. It looks very good.
Please fix the minor test naming issue and we are very close to merging it.
...st/java/org/springframework/ai/autoconfigure/bedrock/BedrockAwsConnectionConfigurationT.java
Outdated
Show resolved
Hide resolved
…der and AwsRegionProvider
89c67ac
to
563f9b4
Compare
Thank you @wmz7year , PR LGTM |
Re-write Bedrock
BedrockAwsConnectionConfiguration
to useAwsCredentialsProvider
andAwsRegionProvider
to manage Amazon Bedrock AI model connections.With this change,
Spring-AI
will provide the capability to customize theAwsCredentialsProvider
andAwsRegionProvider
configurations. Also with this feature,Spring-AI
has capabilities compatible withSpring Cloud AWS
credential management.