Skip to content

Conversation

maxjiang153
Copy link
Contributor

BedrockTitanEmbeddingClient only support configuration embedding type when startup in BedrockTitanEmbeddingProperties.inputType property.

Add new BedrockTitanEmbeddingOptions to support dynamic embedding request types while runtime.

For example:

bedrockTitanEmbeddingClient.call(new EmbeddingRequest(List.of("hello world"),
              BedrockTitanEmbeddingOptions.builder().withInputType(InputType.TEXT).build()));

@tzolov tzolov self-assigned this Apr 26, 2024
@tzolov tzolov added this to the 1.0.0-M1 milestone Apr 26, 2024
@tzolov tzolov assigned markpollack and unassigned tzolov Apr 26, 2024
@maxjiang153 maxjiang153 force-pushed the bedrock-titan-embedding-options branch from af11686 to a50969e Compare April 28, 2024 06:57
@maxjiang153
Copy link
Contributor Author

@tzolov done.

@tzolov
Copy link
Contributor

tzolov commented Apr 28, 2024

Thanks @wmz7year , let me have a look.

@tzolov tzolov merged commit a50969e into spring-projects:main Apr 28, 2024
@maxjiang153 maxjiang153 deleted the bedrock-titan-embedding-options branch April 28, 2024 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants