Skip to content

Conversation

iAMSagar44
Copy link
Contributor

Providing a fix for this issue - #611

…en the document was not uploaded successfully (part of the 'add' method).
…uring application start up. The fix is to create an index only if an index on the embedding column does not exist.
@tzolov tzolov self-assigned this Apr 26, 2024
@tzolov tzolov added this to the 1.0.0-M1 milestone Apr 26, 2024
@tzolov
Copy link
Contributor

tzolov commented Apr 26, 2024

Hi @iAMSagar44 , thanks for the submission.
Have you run the pgvector integration tests?
./mvnw clean install -pl vector-stores/spring-ai-pgvector-store -Pintegration-tests

Caused by: org.postgresql.util.PSQLException: ERROR: syntax error at or near "ON"
  Position: 28

@tzolov
Copy link
Contributor

tzolov commented Apr 26, 2024

I believe you've missed the index name : https://www.postgresql.org/docs/current/sql-createindex.html
I will handle it before the merge.
Thank you again for the contribution, just please make sure to run all tests next time before submitting the pr.

@tzolov
Copy link
Contributor

tzolov commented Apr 26, 2024

Rebase, add missing index name, squash and merge at 773b7bd

@tzolov tzolov closed this Apr 26, 2024
@iAMSagar44
Copy link
Contributor Author

Hi @iAMSagar44 , thanks for the submission.

Have you run the pgvector integration tests?

./mvnw clean install -pl vector-stores/spring-ai-pgvector-store -Pintegration-tests


Caused by: org.postgresql.util.PSQLException: ERROR: syntax error at or near "ON"

  Position: 28

Hi @tzolov,

Thanks for pointing this out.
I did run an integration test after making the change, but I might have made a mistake on running the test on an existing package (I think I missed the 'clean install' maven command).
I will ensure this doesn't happen again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants