Skip to content

Polish #1842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

Polish #1842

wants to merge 4 commits into from

Conversation

@ngocnhan-tran1996
Copy link
Contributor

This PR includes:

  • Use Pattern Matching
  • Use Collections.emptyMap() instead.

I think Collections.emptyMap() return immutable value so we dont need use Collections#unmodifiableMap for wrapping purpose

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Nov 25, 2024
@jgrandja jgrandja self-assigned this Nov 29, 2024
@jgrandja jgrandja added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Nov 29, 2024
@jgrandja jgrandja added this to the 1.4.1 milestone Nov 29, 2024
@jgrandja jgrandja closed this in ed0265b Nov 29, 2024
@jgrandja
Copy link
Collaborator

Thanks for the PR @ngocnhan-tran1996. This is now merged.

@ngocnhan-tran1996 ngocnhan-tran1996 deleted the polish branch November 29, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@jgrandja jgrandja

Labels

type: enhancement A general enhancement

Projects

None yet

Milestone

1.4.1

Development

Successfully merging this pull request may close these issues.

3 participants

@ngocnhan-tran1996 @jgrandja @spring-projects-issues