Allow CI on any branch, skip CD on forks #4737
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scordio
force-pushed
the
skip-cd-on-forks
branch
from
31801e1 to
116b937
Compare
Signed-off-by: Stefano Cordio <[email protected]>
scordio
force-pushed
the
skip-cd-on-forks
branch
from
116b937 to
11bad01
Compare
|
LGTM 👍 Thank you for this PR! |
|
I just noticed that, after yesterday's rebase, the execution took 6 hours and eventually failed. Maybe further optimizations are possible like excluding long running tests from PR executions. I'll try to dig a bit more. |
|
The problem with the stalling build has been there for a while: #4741 The PR might solve it or might not. So far, I couldn't reproduce it locally. |
|
@hpoettker I was working on #4741 just after this PR, which is now merged. Thank you both for your contributions! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, running the
continuous-integration.ymlworkflow on a fork'smainbranch would fail due to the deployment steps, and no CI was executed on branches and pull requests.With this change, the deployment steps are executed only when the current repository is
spring-projects/spring-batchand the branch ismain; otherwise, onlymvn verifyis executed. Plus, CI execution is now available for branches and pull requests (like in this one).