Skip to content

Avoid warning when job parameters are empty with incrementer #4915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 20, 2025
Merged

Avoid warning when job parameters are empty with incrementer #4915

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ...h-core/src/main/java/org/springframework/batch/core/launch/support/SimpleJobOperator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,7 @@
* @author Lucas Ward
* @author Will Schipp
* @author Mahmoud Ben Hassine
* @author Andrey Litvitski
* @since 2.0
* @deprecated since 6.0 in favor of {@link TaskExecutorJobOperator}. Scheduled for
* removal in 6.2 or later.
Expand Down Expand Up @@ -188,7 +189,7 @@ public JobExecution start(Job job, JobParameters jobParameters)
Assert.notNull(job, "The Job must not be null.");
Assert.notNull(jobParameters, "The JobParameters must not be null.");
if (job.getJobParametersIncrementer() != null) {
if (logger.isWarnEnabled()) {
if (!jobParameters.isEmpty() && logger.isWarnEnabled()) {
logger.warn(String.format(
"Attempting to launch job '%s' which defines an incrementer with additional parameters={%s}. Those additional parameters will be ignored.",
job.getName(), jobParameters));
Expand Down