Skip to content

Stop using queryForStream #5045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Stop using queryForStream #5045

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions ...src/main/java/org/springframework/batch/core/repository/dao/jdbc/JdbcJobExecutionDao.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,10 +217,8 @@ public List<JobExecution> findJobExecutions(final JobInstance jobInstance) {
Assert.notNull(jobInstance, "Job instance cannot be null.");
long jobInstanceId = jobInstance.getId();
// TODO optimize to a single query with a join if possible
List<Long> jobExecutionIds = getJdbcTemplate()
.queryForStream(getQuery(GET_JOB_EXECUTION_IDS_BY_INSTANCE_ID), (rs, rowNum) -> rs.getLong(1),
jobInstanceId)
.toList();
List<Long> jobExecutionIds = getJdbcTemplate().queryForList(getQuery(GET_JOB_EXECUTION_IDS_BY_INSTANCE_ID),
Long.class, jobInstanceId);
List<JobExecution> jobExecutions = new ArrayList<>(jobExecutionIds.size());
for (Long jobExecutionId : jobExecutionIds) {
jobExecutions.add(getJobExecution(jobExecutionId));
Expand Down
Loading