Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -50,10 +50,15 @@ public String generateKey(JobParameters source) {
for (String key : keys) {
JobParameter<?> jobParameter = source.getParameter(key);
if (jobParameter != null && jobParameter.identifying()) {
stringBuffer.append(jobParameter);
stringBuffer.append(key).append("=").append(asLegacyParameterValue(jobParameter)).append(";");
}
}
return DigestUtils.md5DigestAsHex(stringBuffer.toString().getBytes(StandardCharsets.UTF_8));
}

private static String asLegacyParameterValue(JobParameter<?> jobParameter) {
return "{" + "value=" + jobParameter.value() + ", type=" + jobParameter.type() + ", identifying="
+ jobParameter.identifying() + '}';
}

}
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,15 @@ void testCreateJobKeyOrdering() {
assertEquals(key1, key2);
}

@Test
void testCreateJobKeyBackwardCompatibility() {
JobParameters jobParameters = new JobParametersBuilder().addString("foo", "bar")
.addString("bar", "foo")
.toJobParameters();
String key = jobKeyGenerator.generateKey(jobParameters);
assertEquals("0e2a48a17d785b4ec5f073a849a79c9d", key);
}

@Test
public void testCreateJobKeyForEmptyParameters() {
JobParameters jobParameters1 = new JobParameters();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@
import org.springframework.jdbc.datasource.embedded.EmbeddedDatabaseType;
import org.springframework.jdbc.support.incrementer.H2SequenceMaxValueIncrementer;
import org.springframework.test.jdbc.JdbcTestUtils;
import org.springframework.util.DigestUtils;

import static org.junit.jupiter.api.Assertions.*;

Expand Down Expand Up @@ -191,4 +192,22 @@ void testCreateDuplicateInstance() {
assertThrows(IllegalStateException.class, () -> jdbcJobInstanceDao.createJobInstance("job", jobParameters));
}

@Test
void testGetExistingLegacyJobInstance() {
JobParameters jobParameters = new JobParametersBuilder().addString("foo", "bar")
.addString("bar", "foo")
.toJobParameters();
String legacySerializedParameters = "bar={value=foo, type=class java.lang.String, identifying=true};"
+ "foo={value=bar, type=class java.lang.String, identifying=true};";
String legacyJobKey = DigestUtils.md5DigestAsHex(legacySerializedParameters.getBytes(StandardCharsets.UTF_8));

jdbcTemplate.update(
"INSERT INTO BATCH_JOB_INSTANCE(JOB_INSTANCE_ID, JOB_NAME, JOB_KEY, VERSION) VALUES (?, ?, ?, ?)", 3L,
"job", legacyJobKey, 0);

JobInstance jobInstance = jdbcJobInstanceDao.getJobInstance("job", jobParameters);
assertNotNull(jobInstance);
assertEquals(3L, jobInstance.getInstanceId());
}

}