Make JFR optional to support minimized JREs without jdk.jfr module#5334
Open
nikitanagar08 wants to merge 1 commit intospring-projects:mainfrom
Open
Make JFR optional to support minimized JREs without jdk.jfr module#5334nikitanagar08 wants to merge 1 commit intospring-projects:mainfrom
nikitanagar08 wants to merge 1 commit intospring-projects:mainfrom
Conversation
TaskExecutorJobOperator.start() creates a JobLaunchEvent which extends jdk.jfr.Event. On minimized JREs without the jdk.jfr module, this causes NoClassDefFoundError: jdk/jfr/Event. This commit wraps the JFR event creation in a try-catch block to handle the case when JFR is not available, allowing Spring Batch to work on minimized JREs without JFR support. Fixes spring-projects#5326 Signed-off-by: Nikita Nagar <permanayan84@gmail.com>
nikitanagar08
force-pushed
the
fix-5326-jfr-optional
branch
from
a398a9f to
2b29dcb
Compare
Author
|
This PR fixes #5326 - ClassNotFoundException when using minimized JREs without the jdk.jfr module. The fix makes JFR optional by wrapping JFR event creation in a try-catch block to handle NoClassDefFoundError, allowing Spring Batch to work on minimized JREs without JFR support. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5326
Problem:
TaskExecutorJobOperator.start() creates a JobLaunchEvent which extends jdk.jfr.Event. On minimized JREs without the jdk.jfr module, this causes NoClassDefFoundError: jdk/jfr/Event.
Solution:
Wrap the JFR event creation in a try-catch block to handle the case when JFR is not available, allowing Spring Batch to work on minimized JREs without JFR support.