Skip to content

Replace System.getProperty("line.separator") with System.lineSeparator() #5341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
quaff wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −4
Open

Replace System.getProperty("line.separator") with System.lineSeparator() #5341

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .../org/springframework/batch/samples/file/patternmatching/internal/OrderLineAggregator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,11 @@
*
* @author Dave Syer
* @author Dan Garrette
* @author Yanming Zhou
*/
public class OrderLineAggregator implements LineAggregator<Order> {

private static final String LINE_SEPARATOR = System.getProperty("line.separator");
private static final String LINE_SEPARATOR = System.lineSeparator();

private Map<String, LineAggregator<Object>> aggregators;

Expand Down
5 changes: 2 additions & 3 deletions ...framework/batch/samples/file/multilineaggregate/MultilineAggregateJobFunctionalTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,9 +47,8 @@ class MultilineAggregateJobFunctionalTests {
@Test
void testJobLaunch() throws Exception {
this.jobOperatorTestUtils.startJob();
assertEquals(EXPECTED_RESULT,
StringUtils.replace(IOUtils.toString(output.getInputStream(), StandardCharsets.UTF_8),
System.getProperty("line.separator"), ""));
assertEquals(EXPECTED_RESULT, StringUtils
.replace(IOUtils.toString(output.getInputStream(), StandardCharsets.UTF_8), System.lineSeparator(), ""));
}

}
Loading