Delay interaction with Lazy CqlSession bean until first required usage #39948
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
Though the CqlSession provided by the CassandraAutoConfiguration can be lazy the configuration for data cassandra triggers early bean instantiation. This commit uses changed API in the data-cassandra project to make use of the intended lazy bean initialization and therefore prevents the application from failing already at startup when cassandra might not (yet) be ready.
christophstrobl
force-pushed
the
data/cassandra/lazy-cql-session-init
branch
from
9ffc776 to
ec29263
Compare
wilkinsona
reviewed
Mar 18, 2024
| @@ -63,7 +65,7 @@ public class CassandraDataAutoConfiguration { | |||
|
|
|||
| private final CqlSession session; | |||
|
|
|||
| public CassandraDataAutoConfiguration(CqlSession session) { | |||
| public CassandraDataAutoConfiguration(@Lazy CqlSession session) { | |||
There was a problem hiding this comment.
I wonder if we should inject and store an ObjectProvider<CqlSession> here rather than relying on the proxying that @Lazy requires.
Edit: Looking more closely, I'm not sure how that would play with the user type resolver below.
There was a problem hiding this comment.
Relying on the proxy was the less invasive variant.
wilkinsona
added
type: enhancement
wilkinsona
changed the title
wilkinsona
pushed a commit
that referenced
this pull request
Apr 10, 2024
Though the CqlSession provided by the CassandraAutoConfiguration can be lazy, the configuration for Data Cassandra triggers early bean instantiation. This commit uses new APIs in Data Cassandra to make use of the intended lazy bean initialization and therefore prevents the application from failing to start up when Cassandra might not yet be ready. See gh-39948
wilkinsona
added a commit
that referenced
this pull request
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Though the
CqlSessionprovided by theCassandraAutoConfigurationcan be lazy, the configuration for data-cassandra triggers early bean instantiation.This PR uses changed API in the data-cassandra project to make use of the intended lazy bean initialization and therefore prevents the application from failing already at startup when cassandra might not (yet) be ready.
Requires: Upgrade to
spring-data:2024.0.0-RC1Depends on: spring-projects/spring-data-cassandra#1485