Skip to content

Conversation

@ruifigueira
Copy link
Contributor

@ruifigueira ruifigueira commented Mar 20, 2024

Currently, MailProperties doesn't support SslBundle configuration. There are scenarios where a client has a SMTP server with a certificate signed by a local CA and we don't have a simple way to configure MailSender to use a different SSL context, and SslBundles seems to be a great fit here.

This PR adds support to SSL configuration using a SslBundle.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Mar 20, 2024
@ruifigueira ruifigueira force-pushed the feature/mail-sender-sslbundle branch from 026b409 to e9b7527 Compare March 20, 2024 17:46
@scottfrederick scottfrederick added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Mar 20, 2024
@scottfrederick scottfrederick added this to the 3.x milestone Mar 20, 2024
@scottfrederick scottfrederick changed the title Feature Request - Add SslBundle support to MailSender Add SslBundle support to MailSender Mar 20, 2024
@ruifigueira ruifigueira force-pushed the feature/mail-sender-sslbundle branch 5 times, most recently from 3b22b8e to fdb86de Compare March 25, 2024 21:16
@ruifigueira
Copy link
Contributor Author

I added some integration tests using a Mailpit testcontainer, both in TLS/SSL mode and using STARTTLS.

@ruifigueira ruifigueira force-pushed the feature/mail-sender-sslbundle branch from f11116c to 6d88fa0 Compare March 26, 2024 20:47
@ruifigueira ruifigueira force-pushed the feature/mail-sender-sslbundle branch from 6d88fa0 to ff5525e Compare May 13, 2024 13:17
Validate both SSL/TLS and STARTTLS modes with SSL bundles against a Mailpit testcontainer
@ruifigueira ruifigueira force-pushed the feature/mail-sender-sslbundle branch from ff5525e to 7c72130 Compare May 17, 2024 00:49
@mhalbritter mhalbritter self-assigned this Jul 4, 2024
mhalbritter pushed a commit that referenced this pull request Jul 4, 2024
mhalbritter added a commit that referenced this pull request Jul 4, 2024
@mhalbritter
Copy link
Contributor

Thanks a lot!

@mhalbritter mhalbritter modified the milestones: 3.x, 3.4.0-M1 Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: enhancement A general enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants