Skip to content

Add tests to ensure private constructor is not used for value object binding #42277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Add tests to ensure private constructor is not used for value object binding #42277

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions ...org/springframework/boot/context/properties/bind/DefaultBindConstructorProviderTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@
*
* @author Phillip Webb
* @author Madhura Bhave
* @author Yanming Zhou
*/
class DefaultBindConstructorProviderTests {

Expand Down Expand Up @@ -92,6 +93,12 @@ void getBindConstructorWhenHasTwoConstructorsWithBothConstructorBindingThrowsExc
.withMessageContaining("has more than one @ConstructorBinding");
}

@Test
void getBindConstructorWhenIsTypeWithPrivateConstructorReturnsNull() {
Constructor<?> constructor = this.provider.getBindConstructor(TypeWithPrivateConstructor.class, false);
assertThat(constructor).isNull();
}

@Test
void getBindConstructorWhenIsMemberTypeWithPrivateConstructorReturnsNull() {
Constructor<?> constructor = this.provider.getBindConstructor(MemberTypeWithPrivateConstructor.Member.class,
Expand Down Expand Up @@ -224,6 +231,13 @@ static class TwoConstructorsWithBothConstructorBinding {

}

static final class TypeWithPrivateConstructor {

private TypeWithPrivateConstructor(Environment environment) {
}

}

static class MemberTypeWithPrivateConstructor {

static final class Member {
Expand Down