Skip to content

Consistently use constants for annotations in ConfigurationMetadataAnnotationProcessor #42311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Consistently use constants for annotations in ConfigurationMetadataAnnotationProcessor #42311

wants to merge 1 commit into from

Conversation

@mushroom528
Copy link
Contributor

@mushroom528 mushroom528 commented Sep 14, 2024 •
edited
Loading

This PR refactors the ConfigurationMetadataAnnotationProcessor class by replacing hardcoded values with constants.

  • All hardcoded values have been replaced with named constants.
  • No functional behavior has been altered.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Sep 14, 2024
@philwebb philwebb added type: task A general task and removed status: waiting-for-triage An issue we've not yet triaged labels Sep 14, 2024
@philwebb philwebb added this to the 3.4.x milestone Sep 14, 2024
@snicoll snicoll modified the milestones: 3.4.x, 3.2.10 Sep 16, 2024
@snicoll snicoll self-assigned this Sep 16, 2024
@snicoll snicoll changed the title Replace hardcoded values with constants in ConfigurationMetadataAnnotationProcessor. Consistently use constants for annotations in ConfigurationMetadataAnnotationProcessor Sep 16, 2024
@snicoll snicoll mentioned this pull request Sep 16, 2024
Closed
snicoll pushed a commit that referenced this pull request Sep 16, 2024
@mushroom528 @snicoll
Replace Configuration fully qualified name by constant
9bcfc72 
See gh-42311
snicoll added a commit that referenced this pull request Sep 16, 2024
@snicoll
Polish "Replace Configuration fully qualified name by constant"
242803d 
See gh-42311
@snicoll snicoll closed this in 99d0805 Sep 16, 2024
@snicoll
Copy link
Member

snicoll commented Sep 16, 2024

Thanks for making your first contribution to Spring Boot, @mushroom528

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@snicoll snicoll

Labels

type: task A general task

Projects

None yet

Milestone

3.2.10

Development

Successfully merging this pull request may close these issues.

4 participants

@mushroom528 @snicoll @philwebb @spring-projects-issues