Skip to content

remove duplicated file name access and use StringBuilder to insert in WebServerPortFileWriter #42411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

remove duplicated file name access and use StringBuilder to insert in WebServerPortFileWriter #42411

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 11 additions & 12 deletions ...ring-boot/src/main/java/org/springframework/boot/web/context/WebServerPortFileWriter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,18 +109,17 @@ protected File getPortFile(ApplicationContext applicationContext) {
return this.file;
}
String name = this.file.getName();
String extension = StringUtils.getFilenameExtension(this.file.getName());
name = name.substring(0, name.length() - extension.length() - 1);
if (isUpperCase(name)) {
name = name + "-" + namespace.toUpperCase(Locale.ENGLISH);
}
else {
name = name + "-" + namespace.toLowerCase(Locale.ENGLISH);
}
if (StringUtils.hasLength(extension)) {
name = name + "." + extension;
}
return new File(this.file.getParentFile(), name);
String extension = StringUtils.getFilenameExtension(name);

StringBuilder builder = new StringBuilder(name);

String suffix = "-" + (isUpperCase(name) ? namespace.toUpperCase(Locale.ENGLISH) : namespace.toLowerCase(Locale.ENGLISH));
if (StringUtils.hasLength(extension))
builder.insert(name.lastIndexOf(extension) - 1, suffix);
else
builder.append(suffix);

return new File(this.file.getParentFile(), builder.toString());
}

private String getServerNamespace(ApplicationContext applicationContext) {
Expand Down