Skip to content

Polishing KotlinConfigurationPropertiesTests to use the same naming style #42427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Polishing KotlinConfigurationPropertiesTests to use the same naming style #42427

wants to merge 1 commit into from

Conversation

@quaff
Copy link
Contributor

@quaff quaff commented Sep 24, 2024

No description provided.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Sep 24, 2024
@wilkinsona
Copy link
Member

wilkinsona commented Sep 24, 2024 •
edited
Loading

I don't think we should make this change as it's the use of @Import that's being tested so the …Importer naming is appropriate. Changing it would also create a mismatch between the Kotlin tests and the Java tests, both of which were added in 090802b. Thanks anyway.

@wilkinsona wilkinsona closed this Sep 24, 2024
@wilkinsona wilkinsona added status: declined A suggestion or change that we don't feel we should currently apply and removed status: waiting-for-triage An issue we've not yet triaged labels Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

status: declined A suggestion or change that we don't feel we should currently apply

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@quaff @wilkinsona @spring-projects-issues