Skip to content

Centralize slash character in static final variable, improves clarity and maintainability. #42462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@ public class EndpointMapping {

private final String path;

private static final String SLASH = "/";

/**
* Creates a new {@code EndpointMapping} using the given {@code path}.
* @param path the path
Expand All @@ -53,10 +55,10 @@ private static String normalizePath(String path) {
return path;
}
String normalizedPath = path;
if (!normalizedPath.startsWith("/")) {
normalizedPath = "/" + normalizedPath;
if (!normalizedPath.startsWith(SLASH)) {
normalizedPath = SLASH + normalizedPath;
}
if (normalizedPath.endsWith("/")) {
if (normalizedPath.endsWith(SLASH)) {
normalizedPath = normalizedPath.substring(0, normalizedPath.length() - 1);
}
return normalizedPath;
Expand Down