Skip to content

Conversation

@ngocnhan-tran1996
Copy link
Contributor

I fixed typo document

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Oct 16, 2024
@wilkinsona wilkinsona added type: task A general task and removed status: waiting-for-triage An issue we've not yet triaged labels Oct 16, 2024
@wilkinsona wilkinsona added this to the 3.3.x milestone Oct 16, 2024
@philwebb
Copy link
Member

Thanks. The tag::code[] comments should not be required, are you seeing problems with those samples?

@philwebb philwebb added type: documentation A documentation update and removed type: task A general task labels Oct 16, 2024
@philwebb philwebb changed the title Update document Update typos and formatting errors in documentation Oct 16, 2024
@philwebb philwebb added the for: merge-with-amendments Needs some changes when we merge label Oct 16, 2024
@wilkinsona
Copy link
Member

As shown in the docs, the Kotlin snippets are empty at the moment: https://docs.spring.io/spring-boot/reference/io/jta.html#io.jta.mixing-xa-and-non-xa-connections

@philwebb
Copy link
Member

Thanks @wilkinsona. We might want to go the other way and update the Java samples to remove the code tag, that way imports can be shown in the sample.

@ngocnhan-tran1996
Copy link
Contributor Author

ngocnhan-tran1996 commented Oct 16, 2024

@philwebb
I removed the code tag in Java sample and reverted Kotlin sample files in my machine. The result is the code snippets are empty, both Java and Kotlin

@wilkinsona
Copy link
Member

I think the includes need to be updated as well to remove [tag=*].

@ngocnhan-tran1996
Copy link
Contributor Author

Thanks @wilkinsona

It works. I will update PR

@philwebb philwebb removed the for: merge-with-amendments Needs some changes when we merge label Oct 16, 2024
@philwebb philwebb changed the title Update typos and formatting errors in documentation Fix typos and formatting errors in documentation Oct 16, 2024
philwebb pushed a commit that referenced this pull request Oct 16, 2024
@philwebb philwebb closed this in 61a1c04 Oct 16, 2024
@philwebb philwebb modified the milestones: 3.3.x, 3.3.5 Oct 16, 2024
@philwebb
Copy link
Member

Thanks very much @ngocnhan-tran1996

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: documentation A documentation update

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants