Skip to content

Add GitHub Issue templates #42770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Conversation

nosan
Copy link
Contributor

@nosan nosan commented Oct 17, 2024

Screenshot 2024-10-17 at 18 01 50

If you think it's a good idea, it might be worth considering adding templates for PRs.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Oct 17, 2024
SECURITY.md Outdated
Comment on lines 1 to 5
# Reporting a Vulnerability

Please, [open a draft security advisory](https://github.com/spring-projects/security-advisories/security/advisories/new) if you need to disclose and discuss a security issue in private with the Spring Boot team. Note that we only accept reports against [supported versions](https://spring.io/projects/spring-boot#support).

For more details, check out our [security policy](https://spring.io/security-policy).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need this as we already inherit the policy from spring-projects/.github. We can just link to https://github.com/spring-projects/spring-boot/security/policy.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added to contact_links but the issue page changed a bit.
Screenshot 2024-10-17 at 19 07 42

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Report a security vulnerability option should be inherited from https://github.com/spring-projects/.github automatically.

@nosan nosan force-pushed the github-templates branch 2 times, most recently from fe4bad1 to cf3c1e3 Compare October 17, 2024 16:06
@nosan
Copy link
Contributor Author

nosan commented Oct 17, 2024

@mhalbritter
I reviewed the issue page at https://github.com/spring-io/start.spring.io/issues/new/choose, and I noticed it includes a Report of a security vulnerability option, but the repository itself does not have a SECURITY.md.

Is it possible to do something similar in the Spring Boot repository? If so, I could remove the link from contact_links

@philwebb philwebb added the for: team-meeting An issue we'd like to discuss as a team to make progress label Oct 17, 2024
@nosan nosan changed the title Add GitHub Issue templates and SECURITY.md Add GitHub Issue templates Oct 17, 2024
@bclozel
Copy link
Member

bclozel commented Oct 18, 2024

We recently applied this in Spring Framework because we had several security reports made public as issues. I'm not sure we have the same problem in the Spring Boot repository at this point.

Also about the issue type, its title is "Issue" which renders as "Issue: Issue" in the GitHub UI. See https://github.com/spring-projects/spring-framework/issues/new?assignees=&labels=&projects=&template=issue.md&title=

@philwebb philwebb added type: task A general task and removed status: waiting-for-triage An issue we've not yet triaged for: team-meeting An issue we'd like to discuss as a team to make progress labels Oct 21, 2024
@philwebb philwebb modified the milestones: 3.2.x, 3.4.x Oct 21, 2024
@snicoll snicoll self-assigned this Oct 22, 2024
@snicoll snicoll modified the milestones: 3.4.x, 3.4.0-RC1 Oct 22, 2024
snicoll pushed a commit that referenced this pull request Oct 22, 2024
snicoll added a commit that referenced this pull request Oct 22, 2024
@snicoll snicoll closed this in baac4cc Oct 22, 2024
@nosan
Copy link
Contributor Author

nosan commented Oct 22, 2024

Thank you, @snicoll

Screenshot 2024-10-22 at 12 38 45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: task A general task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants