Skip to content

Log warning in HikariCheckpointRestoreLifecycle if pool suspension isn't configured #42937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Log warning in HikariCheckpointRestoreLifecycle if pool suspension isn't configured #42937

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bc6939a
add shutdownTimeout to log message
deki Oct 29, 2024
7b3a0b1
add warning for !allow-pool-suspension as new connections will be cre…
deki Oct 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion ...ng-boot/src/main/java/org/springframework/boot/jdbc/HikariCheckpointRestoreLifecycle.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,13 +109,18 @@ public void stop() {
logger.info("Suspending Hikari pool");
this.dataSource.getHikariPoolMXBean().suspendPool();
}
else {
logger.warn(this.dataSource + " is not configured to allow pool suspension. "
+ "This will cause problems when the application is checkpointed. "
+ "Please configure allow-pool-suspension to fix this!");
}
closeConnections(Duration.ofMillis(this.dataSource.getConnectionTimeout() + 250));
}

private void closeConnections(Duration shutdownTimeout) {
logger.info("Evicting Hikari connections");
this.dataSource.getHikariPoolMXBean().softEvictConnections();
logger.debug("Waiting for Hikari connections to be closed");
logger.debug(LogMessage.format("Waiting %s for Hikari connections to be closed", shutdownTimeout));
CompletableFuture<Void> allConnectionsClosed = CompletableFuture.runAsync(this::waitForConnectionsToClose);
try {
allConnectionsClosed.get(shutdownTimeout.toMillis(), TimeUnit.MILLISECONDS);
Expand Down