Skip to content

Use Map.computeIfAbsent where feasible #42951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Use Map.computeIfAbsent where feasible #42951

wants to merge 1 commit into from

Conversation

quaff
Copy link
Contributor

@quaff quaff commented Oct 31, 2024

No description provided.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Oct 31, 2024
@quaff quaff changed the title Polish ConcurrentReferenceCachingMetadataReaderFactory to use Map::computeIfAbsent Use Map::computeIfAbsent where feasible Oct 31, 2024
@mhalbritter mhalbritter added type: task A general task and removed status: waiting-for-triage An issue we've not yet triaged labels Oct 31, 2024
@mhalbritter mhalbritter added this to the 3.4.x milestone Oct 31, 2024
@mhalbritter mhalbritter changed the title Use Map::computeIfAbsent where feasible Use Map,computeIfAbsent where feasible Oct 31, 2024
@mhalbritter mhalbritter changed the title Use Map,computeIfAbsent where feasible Use Map.computeIfAbsent where feasible Oct 31, 2024
@philwebb
Copy link
Member

Thanks for the PR, but I've had some issues in the past using computeIfAbsent with a ConcurrentHashMap so I'd rather not risk changing the code purely for cosmetic reasons.

@philwebb philwebb closed this Oct 31, 2024
@philwebb philwebb added status: declined A suggestion or change that we don't feel we should currently apply and removed type: task A general task labels Oct 31, 2024
@philwebb philwebb removed this from the 3.4.x milestone Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
status: declined A suggestion or change that we don't feel we should currently apply
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@quaff @philwebb @spring-projects-issues @mhalbritter