Skip to content

Conversation

@nosan
Copy link
Contributor

@nosan nosan commented Nov 4, 2024

#42957

I hope I’ve understood this issue correctly, but if not, please feel free to close this PR.

@philwebb philwebb added the type: bug A general bug label Nov 4, 2024
@philwebb philwebb added this to the 3.4.x milestone Nov 4, 2024
@snicoll snicoll changed the title Remove Spring Boot's custom Mockito MockResolver Warning due to duplicate MockResolver extensions Nov 5, 2024
@snicoll snicoll modified the milestones: 3.4.x, 3.4.0 Nov 5, 2024
@snicoll
Copy link
Member

snicoll commented Nov 5, 2024

Thanks @nosan. We can't remove the class itself as it is public API. Rather, we should stop registering by default as we used to be. I did that in 606709a

@snicoll snicoll closed this Nov 5, 2024
@snicoll snicoll added status: declined A suggestion or change that we don't feel we should currently apply and removed type: bug A general bug labels Nov 5, 2024
@snicoll snicoll removed this from the 3.4.0 milestone Nov 5, 2024
@nosan
Copy link
Contributor Author

nosan commented Nov 5, 2024

Thanks @snicoll
I had the same feeling that I could not touch this public class. However, I eventually decided to drop it as there’s a minimal chance that it's being used outside of Spring Boot itself. If anyone is using it, they can switch to SpringMockResolver as an alternative.

Anyway, your solution is better and safer than mine. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: declined A suggestion or change that we don't feel we should currently apply

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants