Fix formatting of "Spring Boot Features" in Use YAML for External Properties #43271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
wilkinsona
requested changes
Nov 22, 2024
There was a problem hiding this comment.
Thanks for the PR, @ngocnhan-tran1996. I've left a comment for your consideration.
| @@ -154,7 +154,7 @@ You can also provide the following System properties (or environment variables) | |||
| No matter what you set in the environment, Spring Boot always loads `application.properties` as described above. | |||
| By default, if YAML is used, then files with the '`.yaml`' and '`.yml`' extensions are also added to the list. | |||
|
|
|||
| TIP: If you want detailed information about the files that are being loaded you can xref:reference:features/logging.adoc#features.logging.log-levels[set the logging level] of `org.springframework.boot.context.config` to `trace`. | |||
| TIP: If you want more detail information about the files that are being loaded you can xref:reference:features/logging.adoc#features.logging.log-levels[set the logging level] of `org.springframework.boot.context.config` to `trace`. | |||
There was a problem hiding this comment.
I don't think this is an improvement as enabling trace level logging will provide detailed information. Please revert.
| @@ -209,7 +209,7 @@ spring.datasource.url=jdbc:mysql://localhost/test | |||
| server.port=9000 | |||
| ---- | |||
|
|
|||
| See xref:reference:features/external-config.adoc#features.external-config.yaml[] in the "`Spring Boot Features'" section for more information about YAML. | |||
| See xref:reference:features/external-config.adoc#features.external-config.yaml[] in the "`Spring Boot Features`" section for more information about YAML. | |||
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
wilkinsona
added
type: documentation
wilkinsona
changed the title
wilkinsona
changed the title
snicoll
pushed a commit
that referenced
this pull request
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.