Polish formatting of log configuration file #43322
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
|
No sure which style is preferred by Spring Boot, but mixing different styles is not good. |
|
Thanks, @quaff.
The
I'm not sure we should do this. It's certainly more than a formatting change as it removes the use of the filters plugin. I think I'd prefer that this part of the changes is reverted. |
1. Remove space before `/>` to keep consistency. 2. Capitalize `filters` for Log4j2. 3. Uppercase log level to keep consistency.
Done, and capitalize |
mhalbritter
added
type: task
snicoll
pushed a commit
that referenced
this pull request
Dec 4, 2024
1. Remove space before `/>` to keep consistency. 2. Capitalize `filters` for Log4j2. 3. Uppercase log level to keep consistency. See gh-43322
snicoll
added a commit
that referenced
this pull request
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/>to keep consistency.filtersfor Log4j2.