Remove redundant null check for sorter #43343
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Jae-Young98 Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@Jae-Young98 Thank you for signing the Contributor License Agreement! |
spring-projects-issues
added
the
status: waiting-for-triage
mhalbritter
added
type: task
mhalbritter
changed the title
mhalbritter
pushed a commit
that referenced
this pull request
Dec 2, 2024
mhalbritter
added a commit
that referenced
this pull request
Dec 2, 2024
|
Thanks @Jae-Young98 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think the second Null check on the classifier field assignment is redundant because its value has already been processed in the previous part of the method. Therefore, I modified it by specifying the sorter that has already been processed.