Remove unnecessary field initialization in @ConfigurationProperties class #43920
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lass Signed-off-by: Yanming Zhou <[email protected]>
spring-projects-issues
added
the
status: waiting-for-triage
|
Thanks for the PR, but if we're going to make a change like this it should be driven by a team decision to adjust our code style. The adjustment would result in a change in Spring Java Format's Checkstyle rules to add the explicit initialization check. It would then be consistently enforced across the whole codebase. |
wilkinsona
added
status: declined
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is redundant to assign field to
nullorfalse.