Skip to content

Remove unused PrometheusProperties.Pushgateway #43922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Remove unused PrometheusProperties.Pushgateway #43922

wants to merge 1 commit into from

Conversation

quaff
Copy link
Contributor

@quaff quaff commented Jan 22, 2025

It's safe to remove it since it's not used anywhere, feel free to close it if I'm wrong.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jan 22, 2025
@wilkinsona
Copy link
Member

Thanks for raising this @quaff as it's led to me realising that our Promtheus Push Gateway support is in a bit of a mess. I've opened #43923 so that we can try to work things out. In the meantime, I don't think we should merge this as it may not be going in the right direction.

@wilkinsona wilkinsona closed this Jan 22, 2025
@wilkinsona wilkinsona added status: superseded An issue that has been superseded by another and removed status: waiting-for-triage An issue we've not yet triaged labels Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
status: superseded An issue that has been superseded by another
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@quaff @wilkinsona @spring-projects-issues