Skip to content

Conversation

jearton
Copy link
Contributor

@jearton jearton commented Feb 12, 2025

This PR renames the variable beans to initializerBean in ServletWebServerApplicationContext.selfInitialize() method to improve readability and clarity.

Since the loop iterates over ServletContextInitializer beans, naming the variable beans is misleading.
Renaming it to initializerBean makes it clearer that it represents a single ServletContextInitializer instance.

No functional changes.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Feb 12, 2025
@philwebb philwebb added type: task A general task and removed status: waiting-for-triage An issue we've not yet triaged labels Feb 12, 2025
@philwebb philwebb changed the title Clarify variable name in ServletWebServerApplicationContext.selfInitialize() Polish variable name in ServletWebServerApplicationContext.selfInitialize() Feb 12, 2025
@philwebb philwebb added this to the 3.3.x milestone Feb 12, 2025
@snicoll snicoll self-assigned this Feb 12, 2025
@snicoll snicoll modified the milestones: 3.3.x, 3.3.9 Feb 12, 2025
snicoll pushed a commit that referenced this pull request Feb 12, 2025
snicoll added a commit that referenced this pull request Feb 12, 2025
@snicoll snicoll closed this in f9540c0 Feb 12, 2025
@jearton jearton deleted the fix-variable-naming branch February 13, 2025 06:01
@jearton jearton restored the fix-variable-naming branch February 13, 2025 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: task A general task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants