-
Notifications
You must be signed in to change notification settings - Fork 41.7k
Refine the handling of OpenTelemetry resource attributes #44494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
351254a to
2f59144
Compare
Signed-off-by: Dmytro Nosan <[email protected]>
|
Another option is to leave things as they are and simply add logic to ignore empty keys.
|
See gh-44494 Signed-off-by: Dmytro Nosan <[email protected]>
|
Thanks @nosan ! |
|
@mhalbritter @nosan sorry for chiming in so late, but I found this in the current code: - shouldn't it say (similarly what it said before) - because, based on the codes and later comments, both would be checked? |
|
I am not sure I understood your question. The current arrangement is:
|
|
In simple terms, if |
|
@nosan that seems like what I would expect. The current BTW you probably read the previous version of my comment, I've edited it to make it obvious what I was expecting here. |
|
I've polished the javadoc in 22781fc |
Relates to #44394
Initially, I considered proposing these changes: main...nosan:spring-boot:gh-44394-1.
However, I eventually realized that it might be too much for this specific case.
This PR aims to eliminate duplications in
OpenTelemetryAutoConfigurationandOtlpMetricsPropertiesConfigAdapter, consolidating everything into a single location.