Skip to content

Wrong jOOQ exception translator with empty db name #44954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Wrong jOOQ exception translator with empty db name #44954

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fc02f0e
fix: default exception translator
MelleD Mar 25, 2025
c953854
add test case
MelleD Mar 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...rg/springframework/boot/autoconfigure/jooq/DefaultExceptionTranslatorExecuteListener.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ public SQLExceptionTranslator apply(ExecuteContext context) {
private SQLExceptionTranslator apply(SQLDialect dialect) {
String dbName = getSpringDbName(dialect);
return (dbName != null) ? new SQLErrorCodeSQLExceptionTranslator(dbName)
: new SQLStateSQLExceptionTranslator();
: new SQLErrorCodeSQLExceptionTranslator();
}

private String getSpringDbName(SQLDialect dialect) {
Expand Down
10 changes: 9 additions & 1 deletion ...ringframework/boot/autoconfigure/jooq/DefaultExceptionTranslatorExecuteListenerTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
package org.springframework.boot.autoconfigure.jooq;

import java.sql.SQLException;
import java.sql.SQLSyntaxErrorException;
import java.util.function.Function;

import org.jooq.Configuration;
Expand Down Expand Up @@ -94,11 +95,18 @@ private ExecuteContext mockContext(SQLDialect dialect, SQLException sqlException
static Object[] exceptionTranslatesSqlExceptions() {
return new Object[] { new Object[] { SQLDialect.DERBY, sqlException("42802") },
new Object[] { SQLDialect.H2, sqlException(42000) },
new Object[] { SQLDialect.H2, new SQLSyntaxErrorException() },
new Object[] { SQLDialect.HSQLDB, sqlException(-22) },
new Object[] { SQLDialect.HSQLDB, new SQLSyntaxErrorException() },
new Object[] { SQLDialect.MARIADB, sqlException(1054) },
new Object[] { SQLDialect.MARIADB, new SQLSyntaxErrorException() },
new Object[] { SQLDialect.MYSQL, sqlException(1054) },
new Object[] { SQLDialect.MYSQL, new SQLSyntaxErrorException() },
new Object[] { SQLDialect.POSTGRES, sqlException("03000") },
new Object[] { SQLDialect.SQLITE, sqlException("21000") } };
new Object[] { SQLDialect.POSTGRES, new SQLSyntaxErrorException() },
new Object[] { SQLDialect.SQLITE, new SQLSyntaxErrorException() },
new Object[] { SQLDialect.SQLITE, sqlException("21000") },
};
}

private static SQLException sqlException(String sqlState) {
Expand Down
Loading