Skip to content

Conversation

DimaVilda
Copy link
Contributor

Reviewed and removed (in case needed) outdated jaxb-api 'excludes' from dependencies.
Note that for "org.liquibase:liquibase-core" we still depend on jaxb-api so I left it untouched!

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Apr 7, 2025
@snicoll
Copy link
Member

snicoll commented Apr 8, 2025

@DimaVilda thanks for this. You need to sign-off your commit for DCO to pass. You can do so by amending your commit to include a Sign-off clause.

@snicoll snicoll added the status: waiting-for-feedback We need additional information before we can continue label Apr 8, 2025
@DimaVilda
Copy link
Contributor Author

DimaVilda commented Apr 8, 2025

@DimaVilda thanks for this. You need to sign-off your commit for DCO to pass. You can do so by amending your commit to include a Sign-off clause.

I see, should be updated now, apologies for such a mess, next MRs will be signed as required

@spring-projects-issues spring-projects-issues added status: feedback-provided Feedback has been provided and removed status: waiting-for-feedback We need additional information before we can continue labels Apr 8, 2025
@DimaVilda DimaVilda force-pushed the remove-outdated-javax-dependencies branch 2 times, most recently from 4228b30 to a662aa8 Compare April 8, 2025 16:10
@philwebb philwebb added type: task A general task and removed status: waiting-for-triage An issue we've not yet triaged status: feedback-provided Feedback has been provided labels Apr 8, 2025
@philwebb philwebb added this to the 3.5.0-RC1 milestone Apr 8, 2025
@philwebb philwebb self-assigned this Apr 8, 2025
@philwebb philwebb changed the title #44853 - revisit excludes on javax.xml.bind:jaxb-api Remove unnecessary excludes on javax.xml.bind:jaxb-api Apr 8, 2025
philwebb pushed a commit that referenced this pull request Apr 8, 2025
@philwebb philwebb closed this in ca5507e Apr 8, 2025
@philwebb
Copy link
Member

philwebb commented Apr 8, 2025

Thanks very much @DimaVilda!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: task A general task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants