Polish ternary operator #45156
Closed
Polish ternary operator #45156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yanming Zhou <[email protected]>
spring-projects-issues
added
the
status: waiting-for-triage
|
Thanks, but we generally negate the test in ternary expressions. |
philwebb
added
status: declined
philwebb
added
type: task
snicoll
changed the title
|
It turns out I didn't quite get the reason we prefer the negation first. After some discussion with @snicoll I've seen the light! We're really trying to enforce |
philwebb
pushed a commit
that referenced
this pull request
Apr 11, 2025
See gh-45156 Signed-off-by: Yanming Zhou <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.