Skip to content

Adapt deprecation level for management.health.influxdb.enabled #46574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

zahra7
Copy link
Contributor

@zahra7 zahra7 commented Jul 28, 2025

Description of Proposed Changes

This pull request marks the management.health.influxdb.enabled property as ERROR-level deprecated in additional-spring-configuration-metadata.json.
It also updates the reference documentation to include a warning about the deprecation and subsequent removal of the InfluxDB Health Indicator.

Broken Behavior

Prior to this change, the documentation did not clearly state that the InfluxDB Health Indicator was deprecated in Spring Boot 3.3 and removed in Spring Boot 3.4.
This could lead users to attempt to use a feature that is no longer supported, resulting in unexpected build failures or runtime errors.

How the Changes Fix It

  • Updates additional-spring-configuration-metadata.json to mark management.health.influxdb.enabled as deprecated at error level, with a clear reason.
  • Adds a [WARNING] admonition block to the data/nosql.adoc file, explicitly informing users about the deprecation in 3.3 and removal in 3.4 of the InfluxDbHealthIndicator.

Related Issues

Fixes #46545

Pre-Submission Checklist

  • Fork the repository and create a new branch.
  • Make changes in the branch (additional-spring-configuration-metadata.json, data/nosql.adoc).
  • Ensure change adheres to the project's coding style/documentation style.
  • Verify the generated documentation locally.
  • Commit changes.
  • Push branch to fork (git push origin fix/issue-46545-influxdb-deprecation).

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jul 28, 2025
Copy link
Member

@snicoll snicoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. You need to Sign-off your commit as the DCO check is failing.

You can push force to your current branch and that'll update this PR

@@ -18,7 +18,12 @@ You can make use of the other projects, but you must configure them yourself.
See the appropriate reference documentation at {url-spring-data-site}.

Spring Boot also provides auto-configuration for the InfluxDB client but it is deprecated in favor of https://github.com/influxdata/influxdb-client-java[the new InfluxDB Java client] that provides its own Spring Boot integration.
[WARNING]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert the change to the doc. We really only intend to document the property here.

@zahra7 zahra7 force-pushed the fix/issue-46545-influxdb-deprecation branch from cde0eed to 668f131 Compare July 28, 2025 13:35
zahra7 added 2 commits July 28, 2025 10:22
…configuration medata additional-spring-configuration-metadata.json (fixes spring-projects#46545)

Signed-off-by: Fatima Filali [email protected]
…configuration medata additional-spring-configuration-metadata.json (fixes spring-projects#46545)

Signed-off-by: Fatima Filali [email protected]
@zahra7 zahra7 force-pushed the fix/issue-46545-influxdb-deprecation branch from 668f131 to e0d2c6b Compare July 28, 2025 14:29
@snicoll snicoll changed the title Fix/issue 46545 influxdb deprecation Adapt deprecation level for management.health.influxdb.enabled Jul 28, 2025
@snicoll snicoll self-assigned this Jul 28, 2025
@snicoll snicoll added type: documentation A documentation update and removed status: waiting-for-triage An issue we've not yet triaged labels Jul 28, 2025
@snicoll snicoll added this to the 3.4.9 milestone Jul 28, 2025
snicoll pushed a commit that referenced this pull request Jul 28, 2025
@snicoll snicoll closed this in 4fbf3a7 Jul 28, 2025
@zahra7 zahra7 deleted the fix/issue-46545-influxdb-deprecation branch July 28, 2025 14:35
@snicoll
Copy link
Member

snicoll commented Jul 28, 2025

@zahra7 thanks for trying and following up. The requested change is c0b2855

@zahra7
Copy link
Contributor Author

zahra7 commented Jul 28, 2025

@snicoll You're welcome, thanks for letting me try.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation A documentation update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adapt deprecation level for management.health.influxdb.enabled
3 participants