-
Notifications
You must be signed in to change notification settings - Fork 41.4k
Adapt deprecation level for management.health.influxdb.enabled #46574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapt deprecation level for management.health.influxdb.enabled #46574
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. You need to Sign-off your commit as the DCO check is failing.
You can push force to your current branch and that'll update this PR
@@ -18,7 +18,12 @@ You can make use of the other projects, but you must configure them yourself. | |||
See the appropriate reference documentation at {url-spring-data-site}. | |||
|
|||
Spring Boot also provides auto-configuration for the InfluxDB client but it is deprecated in favor of https://github.com/influxdata/influxdb-client-java[the new InfluxDB Java client] that provides its own Spring Boot integration. | |||
[WARNING] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please revert the change to the doc. We really only intend to document the property here.
cde0eed
to
668f131
Compare
…configuration medata additional-spring-configuration-metadata.json (fixes spring-projects#46545) Signed-off-by: Fatima Filali [email protected]
…configuration medata additional-spring-configuration-metadata.json (fixes spring-projects#46545) Signed-off-by: Fatima Filali [email protected]
668f131
to
e0d2c6b
Compare
See gh-46574 Signed-off-by: Fatima Filali <[email protected]>
@snicoll You're welcome, thanks for letting me try. |
Description of Proposed Changes
This pull request marks the
management.health.influxdb.enabled
property as ERROR-level deprecated inadditional-spring-configuration-metadata.json
.It also updates the reference documentation to include a warning about the deprecation and subsequent removal of the InfluxDB Health Indicator.
Broken Behavior
Prior to this change, the documentation did not clearly state that the InfluxDB Health Indicator was deprecated in Spring Boot 3.3 and removed in Spring Boot 3.4.
This could lead users to attempt to use a feature that is no longer supported, resulting in unexpected build failures or runtime errors.
How the Changes Fix It
additional-spring-configuration-metadata.json
to markmanagement.health.influxdb.enabled
as deprecated at error level, with a clear reason.[WARNING]
admonition block to thedata/nosql.adoc
file, explicitly informing users about the deprecation in 3.3 and removal in 3.4 of theInfluxDbHealthIndicator
.Related Issues
Fixes #46545
Pre-Submission Checklist
additional-spring-configuration-metadata.json
,data/nosql.adoc
).git push origin fix/issue-46545-influxdb-deprecation
).