Skip to content

Remove StreamBuilderFactoryBeanCustomizer in favor of Spring Kafka's StreamsBuilderFactoryBeanConfigurer #46675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

nosan
Copy link
Contributor

@nosan nosan commented Aug 5, 2025

See #33819

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Aug 5, 2025
@wilkinsona wilkinsona changed the title Deprecate StreamBuilderFactoryBeanCustomizer in favor of StreamsBuilderFactoryBeanConfigurer Remove Boot's StreamBuilderFactoryBeanCustomizer in favor of Spring Kafka's StreamsBuilderFactoryBeanConfigurer Aug 5, 2025
@wilkinsona wilkinsona changed the title Remove Boot's StreamBuilderFactoryBeanCustomizer in favor of Spring Kafka's StreamsBuilderFactoryBeanConfigurer Remove StreamBuilderFactoryBeanCustomizer in favor of Spring Kafka's StreamsBuilderFactoryBeanConfigurer Aug 5, 2025
@wilkinsona wilkinsona added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Aug 5, 2025
@wilkinsona wilkinsona added this to the 4.0.x milestone Aug 5, 2025
…BuilderFactoryBeanConfigurer

This commit removes Boot's StreamBuilderFactoryBeanCustomizer and
updates KafkaStreamsAnnotationDrivenConfiguration to use
Kafka's StreamsBuilderFactoryBeanConfigurer instead of the
nested class KafkaStreamsFactoryBeanConfigurer.

This aligns more closely with how configuration is typically applied.

Signed-off-by: Dmytro Nosan <[email protected]>
@snicoll snicoll modified the milestones: 4.0.x, 4.0.0-M2 Aug 6, 2025
@snicoll snicoll self-assigned this Aug 6, 2025
snicoll pushed a commit that referenced this pull request Aug 7, 2025
This commit removes Boot's StreamBuilderFactoryBeanCustomizer and
updates KafkaStreamsAnnotationDrivenConfiguration to use
Kafka's StreamsBuilderFactoryBeanConfigurer instead of the
nested class KafkaStreamsFactoryBeanConfigurer.

This aligns more closely with how configuration is typically applied.

See gh-46675

Signed-off-by: Dmytro Nosan <[email protected]>
@snicoll snicoll closed this in 544e728 Aug 7, 2025
@snicoll
Copy link
Member

snicoll commented Aug 7, 2025

@nosan thanks again. Just FYI, we can't make a class that's exposed as a Bean private as it makes it impossible to process it with AOT. I've reverted that part.

@nosan
Copy link
Contributor Author

nosan commented Aug 7, 2025

Thanks, @snicoll
I completely forgot about AOT. Thanks for fixing it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants