Skip to content

apply plugin due to fixed issue #46748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

Pankraz76
Copy link

@Pankraz76 Pankraz76 commented Aug 8, 2025

It seems the plugin was not applied right from the beginning making me winder if its because of ht issue being linked:
https://youtrack.jetbrains.com/issue/KT-30276

As its resolved it might be working not, making the workaround obsolete.

Thanks for considering.

@Pankraz76
Copy link
Author

somehow main is not working as well no my system, giving me this error upfront:


> Task :build-plugin:spring-boot-gradle-plugin:antora
(node:4582) [DEP0180] DeprecationWarning: fs.Stats constructor is deprecated.
(Use `node --trace-deprecation ...` to show where the warning was created)

> Task :build-plugin:spring-boot-maven-plugin:antora
(node:4652) [DEP0180] DeprecationWarning: fs.Stats constructor is deprecated.
(Use `node --trace-deprecation ...` to show where the warning was created)

> Task :core:spring-boot:compileJava
Note: Processing Log4j annotations
Note: Annotations processed
Note: Processing Log4j annotations
Note: No elements to process
/Users/vincent.potucek/IdeaProjects/spring-boot/core/spring-boot/src/main/java/org/springframework/boot/context/properties/bind/ValueObjectBinder.java:423: error: [NullAway] Method returns @Nullable String @Nullable [], but overridden method returns String [], which has mismatched type parameter nullability
                public @Nullable String @Nullable [] getParameterNames(Constructor<?> constructor) {
                                                     ^
    (see http://t.uber.com/nullaway )
/Users/vincent.potucek/IdeaProjects/spring-boot/core/spring-boot/src/main/java/org/springframework/boot/logging/structured/StructuredLogFormatterFactory.java:240: error: [NullAway] referenced method returns @Nullable, but functional interface method java.util.function.Function.apply(T) returns @NonNull
                                        ArgumentResolver.from(StructuredLogFormatterFactory.this.instantiator::getArg));
                                                              ^
    (see http://t.uber.com/nullaway )

> Task :buildpack:spring-boot-buildpack-platform:dockerTest FAILED

DockerApiIntegrationTests > pullImage() FAILED
    org.springframework.boot.buildpack.platform.docker.transport.DockerEngineException at DockerApiIntegrationTests.java:39

1 test completed, 1 failed

> Task :core:spring-boot:compileJava FAILED
2 errors

Found test failures in 1 test task:

:buildpack:spring-boot-buildpack-platform:dockerTest
    org.springframework.boot.buildpack.platform.docker.DockerApiIntegrationTests > pullImage()

[Incubating] Problems report is available at: file:///Users/vincent.potucek/IdeaProjects/spring-boot/build/reports/problems/problems-report.html

FAILURE: Build completed with 2 failures.

1: Task failed with an exception.
-----------
* What went wrong:
Execution failed for task ':buildpack:spring-boot-buildpack-platform:dockerTest'.
> There were failing tests. See the report at: file:///Users/vincent.potucek/IdeaProjects/spring-boot/buildpack/spring-boot-buildpack-platform/build/reports/tests/dockerTest/index.html
==============================================================================

2: Task failed with an exception.
-----------
* What went wrong:
Execution failed for task ':core:spring-boot:compileJava'.
> Compilation failed; see the compiler output below.
==============================================================================

Deprecated Gradle features were used in this build, making it incompatible with Gradle 9.0.

You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins.

For more on this, please refer to https://docs.gradle.org/8.14.3/userguide/command_line_interface.html#sec:command_line_warnings in the Gradle documentation.

BUILD FAILED in 34s
370 actionable tasks: 67 executed, 303 up-to-date
➜  spring-boot git:(fix-resolved-issue) 

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Aug 8, 2025
: State
  Fixed

apply false // https://youtrack.jetbrains.com/issue/KT-30276

Signed-off-by: Vincent Potucek <[email protected]>
@Pankraz76 Pankraz76 force-pushed the fix-resolved-issue branch from d7f9eb7 to 7d205e9 Compare August 8, 2025 15:06
@Pankraz76 Pankraz76 marked this pull request as ready for review August 8, 2025 15:06
@snicoll
Copy link
Member

snicoll commented Aug 9, 2025

You need Java 24 to build main.

@snicoll
Copy link
Member

snicoll commented Aug 11, 2025

The build fails for me and those 4 tests don't extend from base as far as I can see so I am not sure what this PR is trying to do. If they were, there are more kotlin tests that'd be affected.

@snicoll snicoll closed this Aug 11, 2025
@snicoll snicoll added status: declined A suggestion or change that we don't feel we should currently apply and removed status: waiting-for-triage An issue we've not yet triaged labels Aug 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: declined A suggestion or change that we don't feel we should currently apply
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants