Skip to content

Annotate ApplicationContextAssert methods with @CheckReturnValue #46766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

scordio
Copy link
Contributor

@scordio scordio commented Aug 11, 2025

See #32683.

@scordio scordio force-pushed the gh-32683-CheckReturnValue branch from 72390fd to 8978e51 Compare August 11, 2025 07:16
@snicoll
Copy link
Member

snicoll commented Aug 11, 2025

See #32683 (comment)

@snicoll snicoll added the status: on-hold We can't start working on this issue yet label Aug 11, 2025
@scordio scordio marked this pull request as draft August 11, 2025 07:30
@scordio
Copy link
Contributor Author

scordio commented Aug 11, 2025

As I need to extend Checkstyle's import-control.xml, would it be fine to add a top-level allow statement close to:

<allow class="org.springframework.lang.Contract" />

or should I define a more fine-grained rule, restricting it to the following packages?

  • org.springframework.boot.test.context.assertj
  • org.springframework.boot.test.json

@snicoll
Copy link
Member

snicoll commented Aug 11, 2025

would it be fine to add a top-level allow statement close to

Yep. The intention is to restrict only to certain AssertJ entry point and this is one of them so I think that's ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: on-hold We can't start working on this issue yet status: waiting-for-triage An issue we've not yet triaged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants