Performance critical tracing code has high overhead due to the use of the Stream API #46838
+47
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
mhalbritter
added
type: bug
Injection and extraction of the tracing context happens on each request. For example, on each call to a Controller or HTTP client. The Stream API used here was showing up on CPU profiling under heavy load. With these changes, the CPU profiling looks better.
philwebb
pushed a commit
that referenced
this pull request
Aug 14, 2025
Update composite tracing support to remove Stream API calls from injection and extraction methods which happen on each request. See gh-46838
|
Thanks @shakuzen! |
wilkinsona
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Injection or extraction of the tracing context happens on each request. For example, on each call with an HTTP client or handled by a Controller that's instrumented. The Stream API used here was showing up on CPU profiling under heavy load. With these changes, the CPU profiling looks better while maintaining the same behavior as before.
Before (Stream API highlighted)
After
