Replace AssertJ internal APIs with alternative implementations #46855
+29
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
Signed-off-by: Stefano Cordio <[email protected]>
scordio
force-pushed
the
assertj-internal-api
branch
from
b33b5ae to
a909abe
Compare
scordio
commented
Aug 17, 2025
| } | ||
|
|
||
| public ItemMetadataAssert isProperty() { | ||
| objects.assertEqual(this.info, this.actual.isOfItemType(ItemType.PROPERTY), true); | ||
| extracting((actual) -> actual.isOfItemType(ItemType.PROPERTY)).isEqualTo(true); |
There was a problem hiding this comment.
I favored the usage of a custom extracting method to leverage the internal propagation of the assertion state.
In case that isn't a crucial feature for the current scope, such lines could also be written as:
Suggested change
| extracting((actual) -> actual.isOfItemType(ItemType.PROPERTY)).isEqualTo(true); | |
| Assertions.assertThat(this.actual.isOfItemType(ItemType.PROPERTY)).isTrue(); |
and the custom extracting method could be deleted.
snicoll
added
type: task
snicoll
pushed a commit
that referenced
this pull request
Aug 18, 2025
See gh-46855 Signed-off-by: Stefano Cordio <[email protected]>
|
Thanks very much again, @scordio. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change replaces the AssertJ internal API usages with alternative implementations.