Hazelcast health indicator reports the wrong status when Hazelcast has shut down due to an out-of-memory error #46877
+49
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed because when the default Out-Of-Memory handler in Hazelcast detects a OOM error, and terminates Hazelcast, it does so on the _node_ but not via the Hazelcast lifecycle manager - and the results is that it is still possible to successfully execute transactions in Hazelcast after this termination. The health indicator should not report UP after Hazelcast has detected an OOM and terminated itself. Signed-off-by: Tommy Karlsson <[email protected]>
spring-projects-issues
added
the
status: waiting-for-triage
snicoll
changed the title
snicoll
added
type: bug
snicoll
pushed a commit
that referenced
this pull request
Aug 19, 2025
This commit improves the Hazelcast health indicator to fail if the Lifecycle manager indicates that the instance is no longer running. This is needed because when the default Out-Of-Memory handler in Hazelcast detects a OOM error, and terminates Hazelcast, it does so on the node but not via the Hazelcast lifecycle manager - and the results is that it is still possible to successfully execute transactions in Hazelcast after this termination. The health indicator should not report UP after Hazelcast has detected an OOM and terminated itself. See gh-46877 Signed-off-by: Tommy Karlsson <[email protected]>
snicoll
added a commit
that referenced
this pull request
Aug 19, 2025
|
Good stuff, thanks @tommyk-gears for making your first contribution to Spring Boot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed because when the default Out-Of-Memory handler in Hazelcast detects a OOM error, and terminates Hazelcast, it does so on the node but not via the Hazelcast lifecycle manager - and the results is that it is still possible to successfully execute transactions in Hazelcast after this termination. The health indicator should not report UP after Hazelcast has detected an OOM and terminated itself.