Skip to content

Polish tests in buildSrc #47095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Polish tests in buildSrc #47095

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions buildSrc/src/test/java/org/springframework/boot/build/ConventionsPluginTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@
* Integration tests for {@link ConventionsPlugin}.
*
* @author Christoph Dreis
* @author Yanming Zhou
*/
class ConventionsPluginTests {

Expand Down Expand Up @@ -77,7 +78,9 @@ void jarIncludesLegalFiles() throws IOException {
out.println(" id 'org.springframework.boot.conventions'");
out.println("}");
out.println("version = '1.2.3'");
out.println("sourceCompatibility = '17'");
out.println("java {");
out.println(" sourceCompatibility = '17'");
out.println("}");
out.println("description 'Test project for manifest customization'");
out.println("jar.archiveFileName = 'test.jar'");
}
Expand Down Expand Up @@ -107,7 +110,9 @@ void sourceJarIsBuilt() throws IOException {
out.println(" id 'org.springframework.boot.conventions'");
out.println("}");
out.println("version = '1.2.3'");
out.println("sourceCompatibility = '17'");
out.println("java {");
out.println(" sourceCompatibility = '17'");
out.println("}");
out.println("description 'Test'");
}
runGradle("assemble");
Expand Down Expand Up @@ -136,7 +141,9 @@ void javadocJarIsBuilt() throws IOException {
out.println(" id 'org.springframework.boot.conventions'");
out.println("}");
out.println("version = '1.2.3'");
out.println("sourceCompatibility = '17'");
out.println("java {");
out.println(" sourceCompatibility = '17'");
out.println("}");
out.println("description 'Test'");
}
runGradle("assemble");
Expand Down
2 changes: 2 additions & 0 deletions .../test/java/org/springframework/boot/build/testing/TestFailuresPluginIntegrationTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@
* Integrations tests for {@link TestFailuresPlugin}.
*
* @author Andy Wilkinson
* @author Yanming Zhou
*/
class TestFailuresPluginIntegrationTests {

Expand Down Expand Up @@ -166,6 +167,7 @@ private void createBuildScript(File dir) {
writer.println("dependencies {");
writer.println(" testImplementation 'org.junit.jupiter:junit-jupiter:5.6.0'");
writer.println(" testImplementation 'org.assertj:assertj-core:3.11.1'");
writer.println(" testRuntimeOnly 'org.junit.platform:junit-platform-launcher'");
writer.println("}");
writer.println();
writer.println("test {");
Expand Down